hsd icon indicating copy to clipboard operation
hsd copied to clipboard

wallet: increase lookahead configuration to 2 ** 32.

Open nodech opened this issue 2 years ago • 3 comments

NOTE This requires migrations so needs to land in 5.x If there are any breaking changes to layout we want in DB, this is probably good time.

nodech avatar Sep 26 '22 13:09 nodech

Coverage Status

Coverage: 68.289% (+0.09%) from 68.203% when pulling fa9cc462bf9a5cd67fe9de8c1eede78159bd3163 on nodech:account-lookahead into 309df94ad5b2874944a32de63b449ac0a542068d on handshake-org:master.

coveralls avatar Sep 26 '22 14:09 coveralls

Concept ACK, didn't test code yet but looks like the right approach with migration. Question: should we add an RPC to bump up lookahead on existing accounts? Looks like the only way to set a non-default lookahead with this branch is when you create something

pinheadmz avatar Sep 28 '22 14:09 pinheadmz

yeah, I believe it only matters when creating account/wallet. Modifying existing accounts lookahead vs adding new account both require rescan to have a proper state, so I would say it will be preferred to just create new wallet/account or recreate account is better in general for that reason. It is easier to understand that adding new account needs rescan.

nodech avatar Sep 28 '22 14:09 nodech

I also rebased your branch on master and will f-push

pinheadmz avatar Jan 05 '23 17:01 pinheadmz