vkdt icon indicating copy to clipboard operation
vkdt copied to clipboard

Bug ? Crop does allow for out of picture cropping !

Open GLLM opened this issue 3 years ago • 3 comments

Crop:crop does allow for out of picture cropping :

Crop setup image

Result in DR: image

Appears the same in lighttable image

Feature or bug ? I may miss a usecase I'm not aware of !

Thanks GLLM

GLLM avatar Sep 19 '22 18:09 GLLM

indeed, i don't have a use case either. maybe people want to keyframe some animation where the image scrolls through or something. i mean restricting it would be more code and taking away power from the user.

but what i think we should have is an "auto-crop" button which makes sure (maybe preserving aspect ratio) that there are no black borders. especially after rotation this can be convenient.

hanatos avatar Sep 23 '22 10:09 hanatos

Auto-crop sounds like a nice solution, indeed. And the preserve ratio is a nice one too, though it's better if can can be unlocked on demand.

Thanks

GLLM avatar Sep 28 '22 19:09 GLLM

And adding this to the straighten functionality would be nice too !

GLLM avatar Sep 28 '22 20:09 GLLM

.. okay i think we have auto crop now and i'll consider the add-black-border cropping a feature for esoteric use cases that i am yet to come up with.

hanatos avatar Jun 26 '23 07:06 hanatos