utils icon indicating copy to clipboard operation
utils copied to clipboard
verified publisher icon hanami

Replace period in underscored string

Open tak1n opened this issue 3 years ago • 2 comments

Related to https://github.com/hanami/hanami/issues/1163

tak1n avatar May 06 '22 23:05 tak1n

Should I open a separate PR against main as it still seems to use the same underscore method as well?

tak1n avatar May 06 '22 23:05 tak1n

The fix looks good, but I am not sure how to approach this because it is backwards breaking behaviour. Probably best to let @jodosha look at it when he has a free moment.

adam12 avatar May 10 '22 00:05 adam12

@tak1n Please take also care of the instance level interface.

Done

tak1n avatar Nov 07 '22 23:11 tak1n