controller icon indicating copy to clipboard operation
controller copied to clipboard
verified publisher icon hanami

Make use to #media_type instead of #content_type to avoid false negatives (e.g., multipart/form-data; boundary=...)

Open wuarmin opened this issue 7 months ago • 3 comments

Hey :wave:

this PR would fix https://discourse.hanamirb.org/t/how-do-you-set-up-a-file-upload-route-correctly-for-a-json-rest-api/1222/3

thanks

wuarmin avatar Jun 03 '25 07:06 wuarmin

This looks great, @wuarmin! Thanks for doing it!

Could you please add one test to demonstrate this working? Your exact example from your forum post would be great.

timriley avatar Jun 03 '25 08:06 timriley

Thanks for reviewing. Yes, I'll see if I can find the time today. Have a nice evening.

wuarmin avatar Jun 03 '25 08:06 wuarmin

I added a test.

wuarmin avatar Jun 03 '25 19:06 wuarmin

@timriley, perhaps you no longer have this important fix on your radar. I just wanted to remind you, as file upload is currently being discussed. It might save you some time.

wuarmin avatar Sep 29 '25 17:09 wuarmin

Thanks @wuarmin, my radar gets a bit flaky sometimes. 😅 I really appreciate the nudge!

timriley avatar Sep 29 '25 23:09 timriley

Thanks @wuarmin for this fix!

timriley avatar Oct 01 '25 12:10 timriley