controller icon indicating copy to clipboard operation
controller copied to clipboard

Readd session errors

Open tak1n opened this issue 3 years ago • 3 comments

Somewhat unhappy with the implementation, but this introduces some tests as well on which we can rely on to refactor this. Feel free to suggest improvements, maybe we could leverage Hanami::Action::Configuration here.

The configuration is already injected into the response object, we could take care to inject it into the request object as well.

Closes https://github.com/hanami/controller/issues/256

tak1n avatar May 18 '22 00:05 tak1n

@tak1n Could you please rebase with main? 🙏

jodosha avatar Oct 03 '22 10:10 jodosha

@jodosha done, also fixed remaining rubocop offenses.

tak1n avatar Oct 03 '22 11:10 tak1n

Fixed in #395.

timriley avatar Oct 17 '22 10:10 timriley