controller icon indicating copy to clipboard operation
controller copied to clipboard

Make `Hanami::Action::{Request,Response}` `#session` and `#flash` to raise `Hanami::Controller::MissingSessionError` when session is not configured

Open jodosha opened this issue 6 years ago • 1 comments

With https://github.com/hanami/controller/pull/250 (v1.2.0) we introduced a new exception (Hanami::Controller::MissingSessionError) which is raised when a dev tries to access Action#session and Action#flash when the HTTP session isn't configured.

In 2.0 (unstable branch), the access to session and flash will be moved from Hanami::Action to Hanami::Action::Request and Response. These two objects need to support the old behavior of raising a Hanami::Controller::MissingSessionError.


This change IS for unstable branch.


Ref https://github.com/hanami/controller/pull/250

jodosha avatar Apr 16 '18 10:04 jodosha

Sorry, that was the wrong click 😄

GustavoCaso avatar Dec 02 '18 15:12 GustavoCaso

Fixed in #379.

timriley avatar Oct 24 '22 10:10 timriley