ajsf
ajsf copied to clipboard
Consider formGroup validity beside the AJV validation on data validation
The only validation used to set JSF validity is the AJV validation so the form is set valid
if every JSON schema validators are satisfied but the errors set directly on formGroup by custom widgets are bypassed.
For example: Custom TinyMCE widget's maxLength
cannot be limited via JSON schema as the content of the WYSIWYG includes HTML code, so we need to do some treatments to setErrors
manually via an additional validator (async) in the widget and we need it to be able to block form submit.
βοΈ Deploy Preview for ajsf ready!
π¨ Explore the source changes: ff31c25e98a4246e4d2b74aa9a8bfb3d135c3be4
π Inspect the deploy log: https://app.netlify.com/sites/ajsf/deploys/61bb2c0ac90aab0008bc315a
π Browse the preview: https://deploy-preview-298--ajsf.netlify.app/
Codecov Report
Merging #298 (ff31c25) into main (880d9c2) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 20.97% 20.97%
=======================================
Files 10 10
Lines 906 906
Branches 363 363
=======================================
Hits 190 190
Misses 657 657
Partials 59 59
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 880d9c2...ff31c25. Read the comment docs.
Removed wrong branch.