Hans Moritz Günther
Hans Moritz Günther
I've tried to replace our cache code with an `lru_cache` (why reinvent the wheel if the Python code developers already provide this?) but they way we cache right doesn't to...
> I am tempted to say we should make _use_caching a @property which [...] This echos an earlier comment by @DougBurke in https://github.com/sherpa/sherpa/pull/2166#pullrequestreview-2606149723 . However, I want to push back...
I still don't think it's needed (I looked that mentions of `_use_caching` and most them are not relevant, e.g. the mention in an issue that says that we don't use...
I suggest that I squash the last few commits and summarize them all as "response to code review" when this is approved, but for now I have them separate to...
> I think there's still work to be done here but this is a useful improvement as is. Absolutely. And some of that work is going on, see e.g. #2256...
I tried the gh web interface for the conflict resolution and that screwed up. I'll do it locally later.On Apr 9, 2025 12:18 PM, Doug Burke ***@***.***> wrote: Those look...
pre-commit.ci autofix
I put that in (in the GH web interface, thus it became two commits). I strongly suggest to squash on merge when you think it's ready - this shouldn't be...
I think I addressed the suggestions. Can someone do a review again?
@taldcroft This was already approved by @neutrinoceros but waiting for you to have a look again. Maybe this just fell through the cracks. I still think it's worthwhile to have...