sidecar icon indicating copy to clipboard operation
sidecar copied to clipboard

Update for Laravel 11, PHP8 and ZipStream 3.1

Open drjdr opened this issue 1 year ago • 9 comments

This will update for php8 and zipstream 3.1

  • Zipstream now uses php named arguments => require php 8
  • Spatie medialibrary 11 composer conflicts with zipstream 2 dependency

TODO: Change MD5 hashes in 2 tests results.

drjdr avatar Dec 31 '23 17:12 drjdr

This will be very helpful! Likewise, I can't install sidecar until this is merged.

iambateman avatar Jan 22 '24 03:01 iambateman

@iambateman in your composer.json add the following as a temporary solution:

        "hammerstone/sidecar": "dev-main",
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/drjdr/sidecar.git"
        }
    ],

drjdr avatar Jan 24 '24 19:01 drjdr

oh nice that's perfect...thanks for your help on that!

iambateman avatar Jan 24 '24 21:01 iambateman

Waiting for this to be merged and released.

justsanjit avatar Jan 30 '24 01:01 justsanjit

I'll take a look at this tomorrow, thanks!

aarondfrancis avatar Mar 20 '24 22:03 aarondfrancis

Looks like Laravel 11 compatibility has already been merged (see #141). It might be worth updating this PR to just update the PHP & Zipstream versions?

duncanmcclean avatar Apr 01 '24 09:04 duncanmcclean

Any update on merging this?

roberttolton avatar Apr 09 '24 06:04 roberttolton

bump

lionslair avatar Apr 11 '24 03:04 lionslair

Can't believe this got stale, since it's such a bummer.

riabiy avatar May 03 '24 01:05 riabiy

@aarondfrancis Thank you ❤️

One lil PR instead of 1000 words 🥹

riabiy avatar May 15 '24 18:05 riabiy

Thank you all for your patience! ❤️ And thank you @drjdr for tackling this initially. I apologize for all the delays.

aarondfrancis avatar May 15 '24 20:05 aarondfrancis