ketrew icon indicating copy to clipboard operation
ketrew copied to clipboard

Correct order of get_values in Server.block_if_empty_at_most?

Open rleonid opened this issue 10 years ago • 1 comments

Should we call get_values before (as done now) or after the time check at. Specifically only if now is past the blocked out time. It seems that get_values is potentially blocking, hence the times may no longer be accurate.

rleonid avatar Oct 29 '15 06:10 rleonid

You probably right, this code is meant to be temporary, all the work on the Persistent_data is supposed to bring Lwt_react to that function which should be woken-up by a “something changed” event.

smondet avatar Oct 31 '15 17:10 smondet