cycledash icon indicating copy to clipboard operation
cycledash copied to clipboard

The pileup view should pop out into a new window

Open jaclynperrone opened this issue 9 years ago • 9 comments

...and update its position as the user clicks on different variants in the Examine page.

This way the user has a little breathing room to read and filter the VCF file as they see fit. I imagine this new window to behave like the browser inspector, but we can hash out its features elsewhere.

jaclynperrone avatar Jun 05 '15 15:06 jaclynperrone

What about having a fixed position within the same window that is hidden when not in use? I feel like pop out windows are not a common design pattern on the web these days.

hammer avatar Jun 05 '15 17:06 hammer

I think that the pop-out pileup view is definitely worth exploring. I'm not convinced it's the right way to go, but I tend to think it'd be an improvement.

Our current setup (which essentially is in a fixed position & hidden when not in use) eats of the majority of screen space, and skipping between pileups is difficult. There are definitely improvements we can make with the in-screen pileup viewer, though.

I am okay with going against the grain on the journey to variant inspection nirvana.

ihodes avatar Jun 05 '15 17:06 ihodes

I agree with @ihodes. I think both options are worth exploring, improving, and validating. As far as design patterns go, I think that the browser inspector serves a similar purpose to what we are doing here. And mind you, that starts out in browser and has the option to pop out in a new window. So maybe that functionality is something worth exploring.

jaclynperrone avatar Jun 05 '15 17:06 jaclynperrone

The browser inspector is exactly what I had in mind. Making popping out an option seems reasonable; making it the default behavior seems odd.

hammer avatar Jun 05 '15 17:06 hammer

Totally. I imagine popping it out on first click will lead to some confusion and loss of context. The cool thing about the browser inspector is that once you pop it out the first time, it stays that way until change your preference. Another behavior worth exploring!

jaclynperrone avatar Jun 05 '15 17:06 jaclynperrone

Looping @danvk in! Here's one of the issues we talked about today.

jaclynperrone avatar Jun 11 '15 22:06 jaclynperrone

@jaclynperrone and my thinking was that when you click "Open Pileup Viewer", it will show a full-page pileup viewer, with some information about the selected row on the top. There will be a button to "pop out" the pileup viewer into a separate window. This setting can be remembered via cookie.

If you click a row on the examine page while the pileup viewer is popped out, it will jump to that variant.

When you close the full-page pileup viewer (by hitting the "x" icon), the variant you were looking at will remain selected. This will facilitate the Inspect at a variant → Comment on that variant workflow.

Full page by default will work well on laptop screens. It's unclear how well it will work on our giganto cinema displays.

danvk avatar Jun 11 '15 22:06 danvk

That sounds awesome, glad to see the popping out functionally revisited!

On Thu, Jun 11, 2015 at 6:52 PM, Dan Vanderkam [email protected] wrote:

@jaclynperrone and my thinking was that when you click "Open Pileup Viewer", it will show a full-page pileup viewer, with some information about the selected row on the top. There will be a button to "pop out" the pileup viewer into a separate window. This setting can be remembered via cookie. If you click a row on the examine page while the pileup viewer is popped out, it will jump to that variant.

When you close the full-page pileup viewer (by hitting the "x" icon), the variant you were looking at will remain selected. This will facilitate the Inspect at a variant → Comment on that variant workflow.

Reply to this email directly or view it on GitHub: https://github.com/hammerlab/cycledash/issues/687#issuecomment-111298605

ihodes avatar Jun 11 '15 22:06 ihodes

@danvk +1 +1 +100

jaclynperrone avatar Jun 11 '15 22:06 jaclynperrone