cycledash
cycledash copied to clipboard
Show project and caller name associated with each comment on runs page
Adding the following metadata to the comments on the runs page will give the user more context:
- project name
- caller name
As a side note, I will be doing some more validation around whether this "Last 5 Comments" section 1) needs to be on the page and 2) needs to be the first thing someone sees. So this issue is not a priority...I just wanted to get it on the board.
Did some more thinking/exploration with this one. I think for now it might make more sense to just include the project name, rather than the caller name as well. I did a couple different mockups with both pieces of info, and showing the caller names (as opposed to Run 322, Run 241, etc) looks confusing**[1]. Sometimes the callers have the same name, and long names will need to be truncated. Showing the ID# instead (ie. Run 322) shows a unique value in a consistent way. In light of that, let's try this approach, which adds the Project Name underneath the author's name[2]**. What do you think?
[1]
[2]
Definitely agree, looks good. Did you consider "project name, run #"? Seems more related than having run # and location on the next line.
On Tue, Sep 8, 2015 at 4:26 PM, Jaclyn Perrone [email protected] wrote:
Did some more thinking/exploration with this one. I think for now it might make more sense to just include the project name, rather than the caller name as well. I did a couple different mockups with both pieces of info, and showing the caller names (as opposed to Run 322, Run 241, etc) looks confusing_[1]. Sometimes the callers have the same name, and long names will need to be truncated. Showing the ID# instead (ie. Run 322) shows a unique value in a consistent way. In light of that, let's try this approach, which adds the Project Name underneath the author's name[2]_.
[1] [image: screen shot 2015-09-08 at 4 05 42 pm] https://cloud.githubusercontent.com/assets/5685044/9746482/3300deec-5646-11e5-97fa-c2ad40478e88.png
[2] [image: screen shot 2015-09-08 at 4 25 52 pm] https://cloud.githubusercontent.com/assets/5685044/9746501/4dd9eb00-5646-11e5-902c-80449d07f65e.png
— Reply to this email directly or view it on GitHub https://github.com/hammerlab/cycledash/issues/607#issuecomment-138689702 .
Thought about it! But at the same time, the location is a subset of that run, which is why they're still together. Also, putting the run link next to a project name of varying length will knock it out of a consistent spot (or break it to two lines), which could be visually distracting.