cycledash icon indicating copy to clipboard operation
cycledash copied to clipboard

Allow projects, BAMs, Runs to be edited

Open ihodes opened this issue 9 years ago • 3 comments

After PR #510 is in. Would be ideal to be able to double-click a text field and have it turn into a editable input field, and be able to save it. Shouldn't allow all fields to be editable (maybe not uri, for example, but definitely notes).

ihodes avatar Mar 06 '15 20:03 ihodes

Editable from API; need to expose via the UI now. (https://github.com/hammerlab/cycledash/pull/617)

ihodes avatar May 21 '15 15:05 ihodes

Projects Here are some mockups to help illustrate this. When dealing with editing and deleting projects, I thought it would be helpful to use the same flow we have in place for comments:

The edit/delete icons will always be visible on each project**[1]. Clicking edit will turn the text fields into inputs while the cancel/save buttons appear[2]. Clicking "cancel" will trigger an alert[3]** and clicking save will save your changes.

[1] 1-project-normal

[2] 2-project-edit-mode

[3] cancel-edit-alert

BAMs and Runs As for the BAMs and Runs, my first design exposed the edit/delete buttons on hover**[4**]. However, I'm open to always having them exposed. I mocked it up to compare, and though there's a ton of visual clutter, there's no question about what functionality is available**[5]**. It would be great to test these two options. Thoughts?

[4] 4-hover-vcf

[5] 5-vcf-hover-pt189

The edit workflow would work a little differently for BAMs and Runs. Clicking edit would pop open the same modal used to upload the file. This time, the fields will be prepopulated so the user can make adjustments and save again[6]. The modal has the functionality and validation that will enable users to upload (new) files and/or link to different BAMs.

[6] 6-edit-run

And finally, as seen in the comments section, clicking delete with trigger an alert asking if you're sure**[7]**. delete-alert

As always, I would love some feedback! Looking forward to getting this functionality into Cycledash :D

jaclynperrone avatar Sep 04 '15 19:09 jaclynperrone

Looks reasonable to me! I'm always one to go for edit/delete appearing on hover. They shouldn't be common actions at all, and I think they'd be discoverable enough.

ihodes avatar Sep 05 '15 13:09 ihodes