cohorts icon indicating copy to clipboard operation
cohorts copied to clipboard

Simplify Cohort default

Open tavinathanson opened this issue 8 years ago • 1 comments

Seems very easy to accidentally forget the following lines at the beginning of functions:

filter_fn = first_not_none_param([filter_fn, cohort.filter_fn], no_filter)
normalized_per_mb = first_not_none_param([normalized_per_mb, cohort.normalized_per_mb], False)

...and thereby not use the Cohort default.

tavinathanson avatar Jul 26 '16 21:07 tavinathanson

Indeed, @jburos ran into this very issue: https://github.com/hammerlab/cohorts/issues/120#issue-171240320

tavinathanson avatar Aug 15 '16 19:08 tavinathanson