cohorts icon indicating copy to clipboard operation
cohorts copied to clipboard

Replace no_filter with None

Open tavinathanson opened this issue 8 years ago • 0 comments

From @arahuja:

We definitely need a way to not filter which no_fitler solves, but for some reason, I'd rather None did that? Does it make sense for filter_fn to have 3 possible args: 'default', a filter fn, or None. Where 'default' goes to the cohort? This way the user never needs to know of anything special, either the default happens or the user specifies a filter function or None? I worry about the discoverability of no_filter and just None being more natural?

tavinathanson avatar Jul 25 '16 14:07 tavinathanson