Hamish Knight

Results 90 comments of Hamish Knight

[SE-0365] Fix issue where implicit self was unexpectedly disallowed in nested closures

> The three failures in the source compatibility suite look unrelated to me Yeah they're also failing on main: https://ci.swift.org/job/swift-main-source-compat-suite/767/

`Decimal.FormatStyle` does not always respect the locale's decimalSeparator

Sure

[Sema]: diagnose implicit strong captures of weak capture list entries

Sorry I didn't get through the rest of this today, I'll try and get to it before the end of the week

[Sema]: diagnose implicit strong captures of weak capture list entries

Sorry! I haven't forgotten about this, I will try again to get to it before the end of the week

[Sema]: diagnose implicit strong captures of weak capture list entries

So sorry again! I want to try and get through this PR this week

[Sema]: diagnose implicit strong captures of weak capture list entries

Thank you! So sorry for never getting back to this, it's back on my queue to review

AST: Re-enable ASTScope invariant check

FYI I'm giving this a shot in https://github.com/swiftlang/swift/pull/80339

[Sema] Fold SequenceExpr in pre-checking pre-walk

@swift-ci please test

[Sema] Fold SequenceExpr in pre-checking pre-walk

@swift-ci please test source compatibility

[Sema] Fold SequenceExpr in pre-checking pre-walk

@swift-ci please smoke test