FayeSwift icon indicating copy to clipboard operation
FayeSwift copied to clipboard

Update to Swift 5

Open be-bert opened this issue 5 years ago • 8 comments

Currently the project is using Swift 3.

be-bert avatar Oct 07 '19 15:10 be-bert

Hi be-bert,

Are you going to update the library to Swift 5? You would do me a great favour. Thank you.

juanjosesanchezesteban avatar Jan 04 '20 21:01 juanjosesanchezesteban

@be-bert @juanjosesanchezesteban hey there, sorry its been a while since I've used Faye! PRs are welcome but i'll try to take a stab at it some time later this month

hamin avatar Mar 02 '20 06:03 hamin

@hamin , can you open up permissions on this repo to allow people to push to remote branches so that we could open a PR? Getting the following error:

ERROR: Permission to hamin/FayeSwift.git denied to RonanMcH.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

RonanMcH avatar Mar 20 '20 14:03 RonanMcH

@RonanMcH the correct way to submit changes is to use pull requests. This feature is not limited to anyone.. after a request has been submitted the owner/maintainer of the repo can approve/reject the changes

shams-ahmed avatar Mar 20 '20 14:03 shams-ahmed

@shams-ahmed thanks but I can't push to a remote branch so I can't open a pull request with any code changes.

RonanMcH avatar Mar 20 '20 14:03 RonanMcH

have you forked the repo?

shams-ahmed avatar Mar 20 '20 15:03 shams-ahmed

No I just clone this repository, checked out a branch and tried to push to it.

RonanMcH avatar Mar 20 '20 15:03 RonanMcH

forking the repo should resolve your issue.

shams-ahmed avatar Mar 20 '20 15:03 shams-ahmed