FayeSwift icon indicating copy to clipboard operation
FayeSwift copied to clipboard

How do I set connection extension?

Open shshalom opened this issue 8 years ago • 5 comments

shshalom avatar Jul 17 '16 09:07 shshalom

I actually haven't yet added extension support. If you would like to add it PR is welcome

hamin avatar Jul 17 '16 13:07 hamin

Hey I just did, and I would've ask for pull request but for some reason git takes the entire file as new one instead of just the modifications.

shshalom avatar Jul 20 '16 15:07 shshalom

@shshalom hi there, sorry for the late response, do you wanna take another stab at adding extensions support from latest master?

hamin avatar Oct 02 '16 01:10 hamin

Hi @hamin, Actually in the past few weeks I've done much more than just adding extensions support. After doing some research, comparing and studying a little bit more about Faye and Bayeux protocols, I noticed that FayeSwift was incomplete, and caused really bad behaviour.

So I found my self refactoring major parts of FayeSwift original code, and I'm happy to say that now it works almost flawlessly, that said, there's few more tasks to be done for it to be "Complete"

If you like I can create a branch with my changes and you can take a look.

shshalom avatar Oct 05 '16 11:10 shshalom

@shshalom most definitely. There were a bunch of changes added to master recently so do take a look at that too. The bayeux protocol part was complete, but still missing transports and probably had some race conditions from when you looked at it. But yes please create a branch and lets get some of your awesome work in here :)

hamin avatar Oct 05 '16 14:10 hamin