rethinkdb-elixir icon indicating copy to clipboard operation
rethinkdb-elixir copied to clipboard

Published 20 hours ago • verified publisher icon hamiltop

Overhaul

Open vaartis opened this issue 6 years ago • 9 comments

I'm not sure if this library is dead or not, but i've done some oberhauling on it, it should fix most of the warnings and make tests pass (except the 2 i didn't figure out how to fix)

vaartis avatar Mar 10 '18 16:03 vaartis

Elixir 1.6 needs OTP 19 or higher. I made a pull request #146 to test all Elixir/OTP compatible versions from 1.3 and upwards. You could merge that and see what happens.

norpan avatar Apr 06 '18 08:04 norpan

I dunno, they fail locally too, with OTP 20

vaartis avatar Apr 06 '18 16:04 vaartis

The ssl test fails because of a bad certificate, and should be removed. The other test that fails does not fail if I replace the test file with the one from master, so it's something in the test itself. I see that you have changed the test to create and remove the test database, perhaps that has something to do with it?

norpan avatar Apr 07 '18 10:04 norpan

I don't really have time to work on it now..

vaartis avatar Apr 11 '18 14:04 vaartis

I can make a new version of this on top of the current master, if you don't have time. Maybe we should fix one thing at a time.

norpan avatar Apr 11 '18 15:04 norpan

Please do make a new one then

vaartis avatar Apr 11 '18 16:04 vaartis

We should probably also use the new "mix format" to make merging easier in the future. I'll make a list of things to fix in a new issue and then we can tick them off.

norpan avatar Apr 12 '18 06:04 norpan

Fixed conflects there were there and rebased on master. Tests should pass i think.

vaartis avatar Apr 16 '18 11:04 vaartis

Im not sure how geospatial tests work but they fail..

vaartis avatar Apr 16 '18 11:04 vaartis