google-calendar-scroll-disabler icon indicating copy to clipboard operation
google-calendar-scroll-disabler copied to clipboard

Doesn't work with New Google Calendar

Open czekaj opened this issue 8 years ago • 32 comments

Google has just released the new Google Calendar web app and the scroll disabler doesn't work anymore.

More info: https://www.blog.google/products/g-suite/time-refresh-introducing-new-look-and-features-google-calendar-web/

czekaj avatar Oct 17 '17 18:10 czekaj

same. macOS 10.13 + Chrome 62.0.3202.62.

chrisrosa avatar Oct 18 '17 16:10 chrisrosa

I'd love to hear @hamen's take on it. I noticed that Google did something ugly with the New Calendar. They switched to a Google Inbox-like UI framework which generates HTML elements randomly and it's much much harder to find what you're looking for. Therefore it may be challenging to write a working Scroll Disabler for it.

czekaj avatar Oct 18 '17 16:10 czekaj

Hi all and thank you for the report. That's unfortunate, but I'm gonna still trying to work this out next weekend 💪🏻

hamen avatar Oct 19 '17 07:10 hamen

Any chance you can give this version a try, please? google-calendar-scroll-disabler.zip

  1. Remove the previous version.
  2. Unpack the .zip file
  3. Chrome -> Extensions -> Load unpacked extension
  4. Reload Google Calendar

Thank you very much 😄

hamen avatar Oct 21 '17 14:10 hamen

Thanks for working on it, Ivan!

It works only partially. So at first, after reloading, it doesn't work and I can still scroll but as soon as I click any day to add an event it starts working.

czekaj avatar Oct 21 '17 22:10 czekaj

There is a 5 seconds timer, because I'm waiting for the asynchronous stuff to load. Can you do a test for me please? Load the page and wait 6 seconds and then try to scroll. If it works, we can think about reducing the timer, looking for the sweet spot. Thanks

hamen avatar Oct 22 '17 07:10 hamen

Thanks Ivan. It's working fairly well. Just one small issue that I have noticed so far is that the scroll is re-enabled after a new event screen is triggered (regardless if the event gets created or the the Esc key is pressed without creating an event).

apphancer avatar Oct 23 '17 10:10 apphancer

This is working fine for me. I can definitely work with a timer. Thanks

chrisrosa avatar Oct 23 '17 20:10 chrisrosa

Hello,

New here. I installed your extension, and when it loads, after the small delay, I lose the ability to scroll all together. What can I provide you to help?

Kevin

MoFugga avatar Oct 26 '17 23:10 MoFugga

Hello, thanks for this extension.

I tried version 0.3:

  • after 5 seconds scroll ability is completely disabled
  • when I click the "next month" button, the scroll will resume as well as without extension

algoroq avatar Oct 30 '17 07:10 algoroq

version 0.3 is working well for me. I'll report back if I find any issues. I'm a light-user.

heyfletch avatar Nov 02 '17 19:11 heyfletch

It work for me BUT the problem is back as soon you save a new event.

DavGoodvibes avatar Nov 08 '17 11:11 DavGoodvibes

Same. Works, until saving a new event.

heyfletch avatar Nov 08 '17 12:11 heyfletch

I have a made a few changes to the code and made a Pull request Can you take a look at Pull request #10

apphancer avatar Nov 08 '17 15:11 apphancer

Thank you for the PR, Martin. I'm gonna look at it ASAP.

hamen avatar Nov 08 '17 17:11 hamen

Appreciate the work on this, will be hammering Google Calendar's feedback form that they still haven't included a setting to disable scrolljacking.

brendanfalkowski avatar Nov 16 '17 02:11 brendanfalkowski

Hi @hamen thank you for this great extension! any plans when 0.3 version will be released for the web store?

x1c0 avatar Jan 09 '18 07:01 x1c0

Hi all and sorry for the delay. I'm gonna be on this next weekend, polish everything and release a new version. Thank you all for the support and your patience <3

hamen avatar Jan 09 '18 11:01 hamen

@hamen Thank you for your work on this! Greatly helpful!

danielosborn avatar Jan 09 '18 20:01 danielosborn

I eventually managed to merge @apphancer https://github.com/alter-ego/google-calendar-scroll-disabler/pull/10 PR : it looks great!

I have just published version 0.4 (still rolling out tho). I gave it a quick test drive. Please, let me know if you see something wrong.

Once again, thank you @apphancer ❤️

hamen avatar Jan 21 '18 10:01 hamen

I am glad my contribution could help. Thanks @hamen for starting this extension in the 1st place

apphancer avatar Jan 22 '18 10:01 apphancer

@hamen Thanks for the continued work on this extension.

I haven't switched over to the new Google Calendar web app design yet, and with this new update, I lost functionality in the old web app design! (Google allows you to choose which app to use at the moment.)

I tested in the new Google Calendar app and it works successfully.

Possible to restore functionality in the old web app, for those of us who prefer it?

Chrome in MacOS 10.13.12

UpstairsEmpire avatar Jan 22 '18 18:01 UpstairsEmpire

Thank you! Working well from my testing.

Hint: try restarting Chrome to get the update. The extension management screen doesn't have a way to manually update apparently.

brendanfalkowski avatar Jan 22 '18 20:01 brendanfalkowski

@hamen The issue is still occurring. I've restarted chrome, reinstalled the extension, restarted my computer and restarted chrome again! I've also confirmed I have been running v0.4

UpstairsEmpire avatar Jan 23 '18 00:01 UpstairsEmpire

v 0.4 does not solve clickjacking for me. Chrome 69. MacOS Mojave.

heyfletch avatar Oct 05 '18 14:10 heyfletch

Please try this PR -> https://github.com/alter-ego/google-calendar-scroll-disabler/pull/15

works for me on Chrome 69 - MacOS Mojave.

x1c0 avatar Oct 08 '18 12:10 x1c0

@x1c0 Thanks! #15 works for me.

heyfletch avatar Oct 08 '18 13:10 heyfletch

A new release is rolling out. Please, give it a try.

hamen avatar Oct 14 '18 15:10 hamen

@hamen Thanks for doing the 0.5 release! It seems to be working for me.

knumat avatar Oct 15 '18 17:10 knumat

@hamen 0.5 release is working perfect for me on MacOS Mojave (10.14) running Chrome 69.0.3497.100 (Official Build) (64-bit).

Now if only we had a Safari version! Pushing my luck? :)

UpstairsEmpire avatar Oct 15 '18 17:10 UpstairsEmpire