docker-flow-letsencrypt
docker-flow-letsencrypt copied to clipboard
hamburml
Multiple proxy services
Thank you for the wonderful service - I use it in production and it works smoothly.
Docker Flow Proxy supports running multiple independent proxy services (see PROXY_INSTANCE_NAME at https://proxy.dockerflow.com/config/). Would it be easy for you to support multiple PROXY_ADDRESS values?
Did it myself - https://github.com/hamburml/docker-flow-letsencrypt/pull/50
Thanks for the PR and the issue.
I don't use Docker Flow anymore and I don't have a setup to test this PR. The changes look right, but I can't be sure that certbot api is still the same. Did you test your changes?
Yes but only manually. I didn’t go through any testing suite. I have been using it in one of my projects with the changes and they work correctly.
Arseniy Banayev [email protected] (407) 462-0998
From: Michael Hamburger [email protected] Sent: Saturday, July 25, 2020 6:20:00 AM To: hamburml/docker-flow-letsencrypt [email protected] Cc: Arseniy Banayev [email protected]; Author [email protected] Subject: Re: [hamburml/docker-flow-letsencrypt] Multiple proxy services (#49)
Thanks for the PR and the issue.
I don't use Docker Flow anymore and I don't have a setup to test this PR. The changes look right, but I can't be sure that certbot api is still the same. Did you test your changes?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/hamburml/docker-flow-letsencrypt/issues/49#issuecomment-663838440, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPDBTZGZQ3M4F6GQWFAEY3R5KWVBANCNFSM4LFJ3UAQ.
I merged it into master.
You could try tag latest and if it works I'll tag it.