gphotos_sort icon indicating copy to clipboard operation
gphotos_sort copied to clipboard

The extension seems to be broken

Open RobiGold1 opened this issue 4 years ago • 8 comments

I made an album with just 10 photos and when I click on the icon and then click on "sort by name" it displays "sorting..." forever. I used this extension before many times and it was OK. In the previous version I noticed a problem in JS and therefore downloaded the new one but now I don't have access to JS and can't show where the problem is. Please help. Thanks sorting URL Version_1 Version_2

RobiGold1 avatar Jun 13 '20 20:06 RobiGold1

Thanks for reporting. It looks Google changed system again. Please check v0.18.

hamada2029 avatar Jun 15 '20 20:06 hamada2029

Thanks !!!

Will do

From: hamada2029 [email protected] Sent: Monday, 15 June, 2020 23:01 To: hamada2029/gphotos_sort [email protected] Cc: RobiGold1 [email protected]; Author [email protected] Subject: [EXT] Re: [hamada2029/gphotos_sort] The extension seems to be broken (#14)

External Email


Thanks for reporting. It looks Google changed system again. Please check v0.18.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hamada2029_gphotos-5Fsort_issues_14-23issuecomment-2D644348146&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=nw5NB_etofRH72EbTegofg&m=opSXDF0hBJelR6Wtb3TQHh76_YwNwSsGl6NR7yUUUGE&s=iDqNs42A8c1GIogt4auDsVAyEsDsvrTvvUm5ene4DQE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEEENM5ZAA4VFP2IINP47PDRWZ4WLANCNFSM4N5EGMKQ&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=nw5NB_etofRH72EbTegofg&m=opSXDF0hBJelR6Wtb3TQHh76_YwNwSsGl6NR7yUUUGE&s=zDtNO5kZ34FSfcNTa8XGHFJWEUrF0G_pkLzzAAO9r2g&e=.

RobiGold1 avatar Jun 16 '20 05:06 RobiGold1

It works !!! ☺

🙏 Thanks for your prompt support!!!

BR,

Robi

From: hamada2029 [email protected] Sent: Monday, 15 June, 2020 23:01 To: hamada2029/gphotos_sort [email protected] Cc: RobiGold1 [email protected]; Author [email protected] Subject: [EXT] Re: [hamada2029/gphotos_sort] The extension seems to be broken (#14)

External Email


Thanks for reporting. It looks Google changed system again. Please check v0.18.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hamada2029_gphotos-5Fsort_issues_14-23issuecomment-2D644348146&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=nw5NB_etofRH72EbTegofg&m=opSXDF0hBJelR6Wtb3TQHh76_YwNwSsGl6NR7yUUUGE&s=iDqNs42A8c1GIogt4auDsVAyEsDsvrTvvUm5ene4DQE&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AEEENM5ZAA4VFP2IINP47PDRWZ4WLANCNFSM4N5EGMKQ&d=DwMCaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=nw5NB_etofRH72EbTegofg&m=opSXDF0hBJelR6Wtb3TQHh76_YwNwSsGl6NR7yUUUGE&s=zDtNO5kZ34FSfcNTa8XGHFJWEUrF0G_pkLzzAAO9r2g&e=.

RobiGold1 avatar Jun 16 '20 19:06 RobiGold1

Hi, Hamada! The script does not seem to order the photos alphanumeric order. I suppose another change was introduced in Google Photos, or I am doing something wrong.

science-code avatar Mar 26 '21 19:03 science-code

Hi, I can not find alphanumeric problem for now. Could you tell me more example?

hamada2029 avatar Mar 28 '21 20:03 hamada2029

@hamada2029 In short, I have albums which are a mix of:

  • standard photos (one photo = one file)
  • panoramic photos (multiple photos assembled into one file)
  • animations (multiple photos assembled into one file)

These three types of files use three different file naming conventions:

  • standard photos: "DSC_8157.jpg" (original filename generated by the camera)
  • panoramic photos: "DSC_8157 - DSC_8162.jpg" (filename generated by the interval of photos used for creating the panorama)
  • animations: "DSC_8157 - DSC_8162.gif" (same approach as for panoramic photos)

When I use the gphotos_sort extension to sort the photos in the album, it orders the panoramic photos and animations in the right order, and then all the standard photos trailing them. So I get: [panorama1, ..., panoramaN, standardPhoto1, ..., standardPhotoN] Concrete example of obtained sorting:

  1. DSC_8082 - DSC_8083.jpg
  2. DSC_8092 - DSC_8097.jpg
  3. DSC_8217 - DSC_8226.gif
  4. DSC_7950.jpg
  5. DSC_7954.jpg

I expect to have this order:

  1. DSC_7950.jpg
  2. DSC_7954.jpg
  3. DSC_8082 - DSC_8083.jpg
  4. DSC_8092 - DSC_8097.jpg
  5. DSC_8217 - DSC_8226.gif How can I obtain this?

Thank you for your help!

science-code avatar Apr 04 '21 17:04 science-code

Please check v0.25. It has a fix for sorting function.

hamada2029 avatar Apr 05 '21 19:04 hamada2029

Thank you, @hamada2029 ! It works as expected.

science-code avatar Apr 05 '21 20:04 science-code