multitail icon indicating copy to clipboard operation
multitail copied to clipboard

Fixed bug

Open actuday6418 opened this issue 2 years ago • 6 comments

The function choose_color strips the provided string of any color codes it may have. This function is run to populate the buffer during the initialisation of the program. However, the result of the function is stored in use_string and not in the string variable. string is instead mutated during the stripping process, and this was earlier being used to populate the buffer. The solution simply copies the value of use_string to string to initialise the buffer correctly.

actuday6418 avatar Aug 22 '21 05:08 actuday6418

As described in #1, the text after the word "start" was not shown in the "scroll view". Now the text is shown, but without color

Screenshot2021-08-2208:53:16

I expect that the "scroll view" shows colored text as the regular view does.

maiermic avatar Aug 22 '21 06:08 maiermic

Are you sure about that? I also thought it was weird, but the program was explicitly calling a function to strip the color codes. I thought this was expected behavior. I'll make another commit removing this.

actuday6418 avatar Aug 22 '21 07:08 actuday6418

Are you sure about that?

Yes, at least I would expect the "scroll back" view to be colored.

maiermic avatar Aug 22 '21 09:08 maiermic

I've updated this PR with a new commit that solves the color issue. screenShot

actuday6418 avatar Aug 22 '21 11:08 actuday6418

On macOS, when I scroll up and reach the end of the file/buffer, the screen (background color of the terminal) flickers light gray. This behavior did not occur before the changes. On Linux, on the other hand, there is no flickering even after the changes. Do you have any idea what this could have been caused by?

maiermic avatar Aug 23 '21 04:08 maiermic

I was wrong. This blinking did occur before the changes. It seems to be a feature, I guess, although it is not part of the Linux build somehow.

maiermic avatar Aug 23 '21 06:08 maiermic