glob icon indicating copy to clipboard operation
glob copied to clipboard

`includeDirs` should default to true, as in D, python, unix find, unix ls, etc

Open timotheecour opened this issue 7 years ago • 2 comments

timotheecour avatar Jul 13 '18 07:07 timotheecour

@timotheecour hmm. It seems more common that I'd want to not match directories, and that's what I'm used to from most libraries in the JS realm. This is a possibility but I don't want to be consistent just for the sake of consistency — it should also be sane.

haltcase avatar Jul 14 '18 14:07 haltcase

not a big deal ultimately whichever way you prefer, however here's 1 more argument: with current default, walkGlobKinds only entries with returns kind=file (real or symlink), so (with default options), the kind argument isn't particularly useful with includeDirs defaulting to true, the kind becomes more meaningful

timotheecour avatar Jul 14 '18 19:07 timotheecour