beautifulhugo icon indicating copy to clipboard operation
beautifulhugo copied to clipboard

Support for "dark mode" in macOS Mojave

Open igorkulman opened this issue 7 years ago • 9 comments

Maybe just switching the text and background color would look fine.

Should be detectable with prefers-dark-interface media query according to How to detect if OS X is in dark mode in browsers?.

igorkulman avatar Sep 24 '18 13:09 igorkulman

Thanks for the link on how to detect this! It's unlikely that I'll make a dark option for this theme any time soon, but I'd be happy to accept a PR if someone wants to give it a shot.

halogenica avatar Nov 08 '18 07:11 halogenica

I've have a dark mode patch running here: https://iscinumpy.gitlab.io. It's a single commit, I can make it into a PR if you want it.

henryiii avatar Sep 18 '19 18:09 henryiii

(Note: iOS will be released on Friday with dark-mode support, followed by iPadOS a week or two later, so this will start affecting more people soon)

henryiii avatar Sep 18 '19 18:09 henryiii

Commit is here: https://github.com/henryiii/beautifulhugo/commit/f64b4735bc6811890a877f388ba3d6c7a00a216e

henryiii avatar Sep 18 '19 18:09 henryiii

Was this commit PR has been completed? I am willing to test this.

ibnunowshad avatar Nov 29 '19 08:11 ibnunowshad

I need to sync it with my copy, I think I’ve polished it a bit over time.

henryiii avatar Nov 29 '19 16:11 henryiii

I need to sync it with my copy, I think I’ve polished it a bit over time.

I wait for your updates. I am eagerly waiting for this update. I am just curious that this feature support for macOS Catalina auto mode. So light and dark themes based on macOS settings.

ibnunowshad avatar Nov 29 '19 17:11 ibnunowshad

Made the PR, @halogenica will need to approve. I've been using it on iscinumpy.gitlab.io for a while now; have had to adjust a few colors at first, but pretty happy with it now.

henryiii avatar Nov 29 '19 20:11 henryiii

The PR#317 was merged. If the commit https://github.com/halogenica/beautifulhugo/commit/8043892164058b207f38fd5ec5c899b01722ffb8 would have had in the body the text Closes. #194 this issue would have been closed automatically on merge..

ottok avatar Sep 25 '22 19:09 ottok