halo icon indicating copy to clipboard operation
halo copied to clipboard

refactor: only select the required index fields when build query index view

Open guqing opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind improvement /area core /milestone 2.13.x

What this PR does / why we need it:

构建查询视图时只选择被使用到的索引字段以节约内存

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

构建查询视图时只选择被使用到的索引字段

guqing avatar Feb 02 '24 09:02 guqing

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.92%. Comparing base (5fdf6c0) to head (97d5f89). Report is 29 commits behind head on main.

Files Patch % Lines
...n/halo/app/extension/index/query/QueryFactory.java 90.00% 0 Missing and 1 partial :warning:
...lo/app/extension/index/IndexedQueryEngineImpl.java 92.85% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5312      +/-   ##
============================================
+ Coverage     56.91%   56.92%   +0.01%     
- Complexity     3319     3342      +23     
============================================
  Files           587      588       +1     
  Lines         18968    19077     +109     
  Branches       1401     1409       +8     
============================================
+ Hits          10795    10859      +64     
- Misses         7594     7635      +41     
- Partials        579      583       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 02 '24 09:02 codecov[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 26 '24 04:02 sonarqubecloud[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [JohnNiang,ruibaby]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

f2c-ci-robot[bot] avatar Feb 27 '24 09:02 f2c-ci-robot[bot]