halo icon indicating copy to clipboard operation
halo copied to clipboard

提供多种类型的 Favicon 设置

Open ruibaby opened this issue 3 years ago • 4 comments

你当前使用的版本

2.0.2

描述一下此特性

期望提供多种类型的 Favicon 设置,包括针对不同设备,显示大小,Console 端等。

来源:

  1. https://github.com/halo-dev/console/pull/788#issuecomment-1360677436
  2. https://github.com/halo-dev/halo/pull/2582#issuecomment-1280464613

附加信息

No response

ruibaby avatar Dec 21 '22 02:12 ruibaby

/kind feature /area core /area console

ruibaby avatar Dec 21 '22 03:12 ruibaby

/milestone 2.2.x

ruibaby avatar Dec 29 '22 04:12 ruibaby

/good-first-issue

ruibaby avatar Jan 11 '23 10:01 ruibaby

@ruibaby: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot[bot] avatar Jan 11 '23 10:01 f2c-ci-robot[bot]

/assign @L-fw

wan92hen avatar Apr 20 '23 02:04 wan92hen

@wan92hen: GitHub didn't allow me to assign the following users: L-fw.

Note that only halo-dev members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @L-fw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot[bot] avatar Apr 20 '23 02:04 f2c-ci-robot[bot]

/assign

L-fw avatar Apr 20 '23 02:04 L-fw

这个功能感觉不需要再提供设置项了让用户配置了,只需要基于之前已有的 Favicon 设置,如果用户设置了图片则根据那个图片生成几种标准尺寸的缩略图作为 Favicon 然后自动填充到模板页的 head 即可:

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
<link rel="manifest" href="/site.webmanifest">

参考:

  • https://favicon.io/favicon-generator/
  • https://en.wikipedia.org/wiki/Favicon

guqing avatar Apr 20 '23 03:04 guqing

好的

L-fw avatar Apr 20 '23 03:04 L-fw