halo icon indicating copy to clipboard operation
halo copied to clipboard

feat: post support sorting by number of comments

Open Raremaa opened this issue 2 years ago • 7 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Get posts with most comments.

Which issue(s) this PR fixes: Fixes #2171

Special notes for your reviewer: The performance is not very good,and based on that,the community advice is needed.

Does this PR introduce a user-facing change? None

Raremaa avatar Jul 09 '22 11:07 Raremaa

@Raremaa: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot[bot] avatar Jul 09 '22 11:07 f2c-ci-robot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 09 '22 11:07 CLAassistant

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign guqing after the PR has been reviewed. You can assign the PR to them by writing /assign @guqing in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

f2c-ci-robot[bot] avatar Jul 09 '22 11:07 f2c-ci-robot[bot]

@Raremaa 感谢你的贡献。请先按照 https://github.com/halo-dev/halo/pull/2229#issuecomment-1179527735 的要求 Sign 一下我们的 CLA。另外,请按照我们的 Pull Request 模板修改一下 PR 描述。

ruibaby avatar Jul 09 '22 11:07 ruibaby

/retitle feat: post support sorting by number of comments

ruibaby avatar Jul 09 '22 11:07 ruibaby

好滴 我晚上修改一下~

Raremaa avatar Jul 11 '22 05:07 Raremaa

@ruibaby

  • CLA已sign
  • 代码风格已调整
  • PR描述已修改

Raremaa avatar Jul 11 '22 11:07 Raremaa

由于 1.x 的版本已经进入维护阶段,不会添加新功能,并且此 PR 也已经不适用于 2.x,所以我将关闭此 PR。

再次感谢你的贡献。

/close

ruibaby avatar Mar 07 '23 06:03 ruibaby

@ruibaby: Closed this PR.

In response to this:

由于 1.x 的版本已经进入维护阶段,不会添加新功能,并且此 PR 也已经不适用于 2.x,所以我将关闭此 PR。

再次感谢你的贡献。

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot[bot] avatar Mar 07 '23 06:03 f2c-ci-robot[bot]