valid_email icon indicating copy to clipboard operation
valid_email copied to clipboard

v0.1.4 broke custom messages

Open donncha opened this issue 3 years ago • 3 comments

Currently producing validation messages like "Customer Email {:message=>"is invalid"}".

Specifically, in EmailValidator

record.errors.add attribute, message: (msg % {value: value})

should revert to

record.errors.add attribute, (msg % {value: value})

donncha avatar Dec 06 '21 06:12 donncha

Yes. Previously I was getting the errors in the same as rails format record.errors[:email] # => ['is invalid'], but now it's record.errors[:email] # => [{:message=>' is invalid'}]

oleksiivykhor avatar Dec 19 '21 15:12 oleksiivykhor

It looks like this behavior was changed in https://github.com/hallelujah/valid_email/pull/118

stevendaniels avatar Mar 28 '23 14:03 stevendaniels

@hallelujah Shall we close this issue after https://github.com/hallelujah/valid_email/pull/125 was merged?

arturoherrero avatar Oct 04 '23 13:10 arturoherrero