xamarin-range-slider icon indicating copy to clipboard operation
xamarin-range-slider copied to clipboard

Published 20 hours ago • verified publisher icon halkar

Fix iOS RangedSlider in iOS page/formsheets, and added active color support for iOS

Open Tommigun1980 opened this issue 4 years ago • 6 comments

This fixes https://github.com/halkar/xamarin-range-slider/issues/167, by stopping event propagation when slider is dragged.

This also implements https://github.com/halkar/xamarin-range-slider/issues/150, by adding ActiveColor support for iOS. Screenshot 2020-08-23 at 1 34 23

Tommigun1980 avatar Aug 22 '20 12:08 Tommigun1980

The CI issues seem to have to do with the CI system and not this PR.

Tommigun1980 avatar Aug 22 '20 22:08 Tommigun1980

Please note that if ActiveColor is not set the tint will default to system tint. To make it white, one has to set ActiveColor to white.

Tommigun1980 avatar Aug 22 '20 22:08 Tommigun1980

Hi.

Any chance these fixes and enhancements could be accepted and a new version be released?

Thanks.

Tommigun1980 avatar Sep 05 '20 06:09 Tommigun1980

@Tommigun1980

  1. The build is broken (just comment sonarqube for now).
  2. You are changing the default behaviour. If you want to change it you can use the same Material UI flag.
  3. Don't rename properties just because you don't like the original naming convention.

halkar avatar Sep 07 '20 09:09 halkar

@Tommigun1980

  1. The build is broken (just comment sonarqube for now).
  2. You are changing the default behaviour. If you want to change it you can use the same Material UI flag.
  3. Don't rename properties just because you don't like the original naming convention.

Hi.

  1. What do you mean with "just comment sonarcube"? The build seems to fail from some CI things outside of this pull request.
  2. What behaviour are you referring to, the default color? In that case shouldn't the default behaviour be what is native behaviour? Also what do you mean with the same Material UI flag - do you want the colouring behaviour to be enabled via it?
  3. Oh sorry, that was unintentional, I think it was one of those VS auto-fix things. I can put it back.

Tommigun1980 avatar Sep 07 '20 09:09 Tommigun1980

  1. Sorry, I was referring to lines https://github.com/halkar/xamarin-range-slider/blob/master/build.cake#L54 and https://github.com/halkar/xamarin-range-slider/blob/master/build.cake#L56
  2. Yes, I understand that the current behaviour maybe not perfect but existing programs may rely on it. Yes, I was talking about the old Material UI flag.

halkar avatar Sep 07 '20 10:09 halkar