BetterVideoPlayer icon indicating copy to clipboard operation
BetterVideoPlayer copied to clipboard

Missing FadingCircle of SpinKitView after adding to gradle

Open devingDev opened this issue 6 years ago • 4 comments

-- [ x] I have verified there are no duplicate active or recent bugs, questions, or requests -- [x ] I have verified that I am using the latest version of Better Video Player. -- [ x] I have given my issue a non-generic title. -- [ x] I have read over the documentation (before asking questions on how to do something).

-###### Include the following:

    • Better Video Player version: 1.2.alpha1

-###### Reproduction Steps

-1. Added to both gradle files what was written in README -2. Wait for gradle to sync -3. Thats it now I got that error

-###### Expected Result

  • It shouldn't error and work

-###### Actual Result This error (Android issues) : error: resource style/SpinKitView.Large.FadingCircle (aka com.test.app:style/SpinKitView.Large.FadingCircle) not found. Message{kind=ERROR, text=error: resource style/SpinKitView.Large.FadingCircle (aka com.test.app:style/SpinKitView.Large.FadingCircle) not found., sources=[C:\Users\Fesvz\.gradle\caches\transforms-1\files-1.1\BetterVideoPlayer-1.2.alpha1.aar\ee6a6260a7f6e32e34ed3274b1083750\res\layout\bvp_include_progress.xml:7], original message=, tool name=Optional.of(AAPT)}

devingDev avatar May 10 '18 23:05 devingDev

I seem to have the same problem. Is there a possible fix in the works?

UGhari avatar May 19 '18 19:05 UGhari

Seems like animation icons are missing.

I was able to fix the issue by using https://github.com/ybq/Android-SpinKit dependencies { compile 'com.github.ybq:Android-SpinKit:1.1.0' }

srini17 avatar May 23 '18 21:05 srini17

Library already has this dependency?

https://github.com/halilozercan/BetterVideoPlayer/blob/master/bettervideoplayer/build.gradle#L31

halilozercan avatar May 24 '18 14:05 halilozercan

Hmm that is very strange yes you already have that dependancy. I added it the spinKIT to my own project anyway just to see if it works and it does now both successfully compile. Very strange though

implementation 'com.github.halilozercan:BetterVideoPlayer:1.2.alpha1'
implementation 'com.github.ybq:Android-SpinKit:1.1.0'

UGhari avatar May 24 '18 17:05 UGhari