Halide icon indicating copy to clipboard operation
Halide copied to clipboard

The version check in serialization is not checked at the right place

Open abadams opened this issue 1 year ago • 1 comments

We need to check the version number first, before trying to serialize or deserialize anything. Currently if you pass a serialization file of the wrong version it can just crash before the version check.

abadams avatar Feb 16 '24 21:02 abadams

There should be a correctness test that tests loading serialization files of the wrong version and makes sure the right error is generated

abadams avatar Feb 16 '24 21:02 abadams

Did this ever get fixed?

abadams avatar Jun 05 '24 19:06 abadams

I believe so, I recently did something similar to the issue's description and triggered the proper check and error messages

TH3CHARLie avatar Jun 05 '24 20:06 TH3CHARLie