Problems with TeamCity 9.1.5

[embee1981]

I've encountered a few problems with the plugin and TeamCity 9.1.5. The thread spawned from the BuildTracker class never seemed to finish even though a build had successfully ran. This is causing the server logs to roll over almost instantaneously, filling up with parameter logging from the thread.

The second issue I've encountered is that builds that did not have the phabricator build feature enabled acted as though they had the feature enabled once a build that uses pharbicator has ran. I think this is because of the AppConfig field being a member variable of various classes and holding onto stale data. Its parse() method should set enabled to false and all the other variables relating to state such as diffId etc to null at the start of the method, otherwise these will still be set from a previous run of parse() and the state will remain enabled, despite no config being present for supplied config

[embee1981]

One other change to possibly make as well would be to add a check to Agent's runnerFinished() method, only reporting to harbourmasterbuildstatus if appConfig.isEnabled() is true.

[dclarke]

embee1981, any desire to work on a rewrite of this plugin with me ?