enable generate_product_version to work with multiple target per cmake file; fix language

Open dothebart opened this issue 10 years ago • 1 comments

First, thanks for your nice scripts, it was an excelent starting point. since over at Arangodb we have several targets in one CMakeList.txt, I had to alter it a little: I've added the 'NAME' attribute to the filenames, and thus I've added it to the #include line in VersionResource.rc: https://github.com/arangodb/arangodb/commit/2d23ce989c1247708fba0640d48b52b04ece175c You will also note the change of 'BLOCK "040904b0"' which makes the binary be declared as English instead of russian ;-) maybe there should be something inside of generate_product_version.cmake building these strings. Since NAME now rather is a filename, I'm using the FILE_DESCRIPTION argument too.

Jul 20 '15 12:07 dothebart

Thank you for your feedback! I'd like to commit your changes as soon as I have spare time. :+1:

Jul 20 '15 14:07 halex2005