hale icon indicating copy to clipboard operation
hale copied to clipboard

build: update groovy version to 4.0.1

Open kapil-agnihotri opened this issue 2 years ago • 5 comments

Migrate from groovy 2.4 to 4.0.1 and Migrate from pegdown to flexmark-java markdown parser 0.64

Other related PRs

ING-3268

kapil-agnihotri avatar Sep 09 '22 11:09 kapil-agnihotri

Converted this PR to draft, as the build will not be successful until the target platform repos are updated.

kapil-agnihotri avatar Sep 12 '22 07:09 kapil-agnihotri

retest this please

kapil-agnihotri avatar Sep 12 '22 14:09 kapil-agnihotri

retest this please

kapil-agnihotri avatar Sep 12 '22 14:09 kapil-agnihotri

Thanks a lot @stempler for your feedback.

Did you try the build locally? Did it succeed there?

Yes, I did and it succeeded. Also, I can run the application after setting the new target platform with the latest commit IDs.

kapil-agnihotri avatar Sep 12 '22 15:09 kapil-agnihotri

Thanks a lot @stempler for your feedback.

Did you try the build locally? Did it succeed there?

Yes, I did and it succeeded. Also, I can run the application after setting the new target platform with the latest commit IDs.

I didn't try to build the application using the build scripts from the build folder but from the eclipse. I misunderstood building locally with the eclipse build. I am trying to build from the scripts now.

kapil-agnihotri avatar Sep 14 '22 12:09 kapil-agnihotri

@stempler , should I delete all *.tycho-consumer-pom.xml from the PR ?

kapil-agnihotri avatar Nov 01 '22 13:11 kapil-agnihotri

should I delete all *.tycho-consumer-pom.xml from the PR ?

@kapil-agnihotri Definitely, thank you.

Is the PR otherwise up-to-date? Is another hale-build-support update needed?

stempler avatar Nov 01 '22 13:11 stempler

Hi @stempler, the PR is up-to date.

  • I have removed all *.tycho-consumer-pom.xmlfrom the PR
  • Also, recreated hale-build-support update-site with sources enabled and here is the link for the merge requests https://gitlab.wetransform.to/hale/hale-build-support/merge_requests

Once hale-build-support is merged, I will update the target platform and commitID for JRE repositories.

kapil-agnihotri avatar Nov 02 '22 10:11 kapil-agnihotri

I have also updated the builds created today with the reverted changes on box

kapil-agnihotri avatar Nov 10 '22 08:11 kapil-agnihotri