hale icon indicating copy to clipboard operation
hale copied to clipboard

Add option to database readers to automatically create Join relations found in the schema

Open JohannaOtt opened this issue 5 years ago • 7 comments
trafficstars

When reading the source schema from a database, relations between tables/types should be analysed and imported so that conditions for Joins do not need to be created manually. One option would be to directly create/suggest Join functions with the imported relations. This would espeacially be helpful when a lot of tables need to be included in the alignment. A less obtrusive option would be, to enter the Join conditions in the Join creation workflow so that, if the user decides to create the Join, the Join conditions are already prefilled.

JohannaOtt avatar Dec 23 '19 11:12 JohannaOtt

According 'Mapping database schemas' in http://help.halestudio.org/latest/topic/eu.esdihumboldt.hale.doc.user/html/reference/import/jdbc.html?cp=0_6_2_0_8, there is already something implemented that supports users. @florianesser @stempler Should that ticket be kept to improve the existing functionality or is there nothing more that can be implemented in that context?

JohannaOtt avatar May 13 '20 09:05 JohannaOtt

@JohannaOtt Did you originally create this ticket because you imported a database schema and the Joins were not automatically detected?

florianesser avatar May 13 '20 09:05 florianesser

@florianesser The question if that would be possible came up during a workshop. As I did not know that there is such a functionality already, I created this ticket as I agreed that this would be very helpful. IIRC we did not test a concrete use case back then though.

JohannaOtt avatar May 13 '20 11:05 JohannaOtt

@JohannaOtt Could you test if the existing behaviour works like you would expect?

florianesser avatar May 14 '20 13:05 florianesser

@florianesser The current behavior is the one described as the 'less obtrusive option' in the tickets description. When importing a database schema from a PostgreSQL database containing a relation between two tables, the Join condition is prefilled when creating a Join: grafik

So from my point of view, this ticket could be either closed or kept as an improvement to implement the first option described (directly create/suggest Join functions with the imported relations).

JohannaOtt avatar May 20 '20 07:05 JohannaOtt

@JohannaOtt Thanks for testing!

So from my point of view, this ticket could be either closed or kept as an improvement to implement the first option described (directly create/suggest Join functions with the imported relations).

I think we can keep it as an enhancement. I'd favour an implementation where this is added as an option somewhere in the importer, so that the user can choose between the "less obstrusive" and the "more obstrusive" variant.

florianesser avatar May 20 '20 07:05 florianesser

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 13 '24 02:05 github-actions[bot]