use-mobile-detect-hook icon indicating copy to clipboard operation
use-mobile-detect-hook copied to clipboard

add caching, change API, update major version

Open dillonstreator opened this issue 2 years ago • 4 comments

fix #25

dillonstreator avatar Jul 30 '22 19:07 dillonstreator

@haldarmahesh curious your thoughts on this as it is a breaking change that requires a major version uptick. there is a way to not break the api and instead cache each of the individual function calls but this api change felt better

dillonstreator avatar Jul 30 '22 19:07 dillonstreator

hey @dillonstreator thanks for raising the PR, let me also look into this and feedback if any. :)

haldarmahesh avatar Aug 01 '22 12:08 haldarmahesh

hi @haldarmahesh any updates? appreciate any feedback

dillonstreator avatar Aug 12 '22 14:08 dillonstreator

@haldarmahesh thoughts on this?

dillonstreator avatar Nov 12 '22 20:11 dillonstreator