asdf-java icon indicating copy to clipboard operation
asdf-java copied to clipboard

`IBM Semeru Runtime Open Edition` missing

Open MPV opened this issue 1 year ago • 3 comments

It seems it disappeared with this recent update:

  • https://github.com/halcyon/asdf-java/commit/479f3f8a212cb44b4e6610b4a604b4bd91461c00#diff-9ca415b8219a52bbc6b30cf35df4819d5f03ef2b167bf4b5f0522602619f7fd2

Was it replaced by IBM Semeru Runtime Certified Edition...?

Looking here, I see it's possible to select them both: https://developer.ibm.com/languages/java/semeru-runtimes/downloads/

And this blog post describes some differences (in licensing) between them: https://developer.ibm.com/blogs/launch-of-ibm-semeru-runtime-certified-edition-11/

MPV avatar Jul 04 '24 12:07 MPV

I also raised an upstream issue at:

  • https://github.com/joschi/java-metadata/issues/46

MPV avatar Jul 04 '24 12:07 MPV

For comparison, this is not what I'm expecting:

$ asdf list all java | grep semeru | wc -l
       0

MPV avatar Jul 04 '24 14:07 MPV

The issue has been fixed upstream (https://github.com/joschi/java-metadata/tree/6f3fbb4de149eb163214c2d476c3a9afc74e7ce6) and this repository will pick up the changes with the next update run (https://github.com/halcyon/asdf-java/actions/workflows/update-data.yaml).

joschi avatar Jul 04 '24 18:07 joschi

@joschi Could you please have another look at this?

I'm still seeing "Certified" semeru tar files being referred to alongside the "Open" ones.

They are indistinguishable via asdf list-all java | grep semeru-openj9-11.0, except for when you install them and you run java --version and see the wrong distribution was installed.

Here's an example of a commit that adds a Certified where I expected an Open:

  • https://github.com/halcyon/asdf-java/commit/4a1fbd1d#diff-f03a5dcd717a64a39cd2795a48475d09d520950a2c657b26be4318a0d5e3c035

MPV avatar Jun 04 '25 11:06 MPV

It looks like that due to the logic in update_data.bash the variants open and certified and up with the same identifier and the first one (sorted alphabetically) wins.

https://github.com/halcyon/asdf-java/blob/d5c23f25d751c2f7e49416b5589d3aca49e418d4/update_data.bash#L56

Example:

semeru-jre-openj9-11.0.19+7_openj9-0.38.0	ibm-semeru-certified-jre_x64_linux_11.0.19.0.tar.gz	https://github.com/ibmruntimes/semeru11-certified-binaries/releases/download/jdk-11.0.19+7_openj9-0.38.0/ibm-semeru-certified-jre_x64_linux_11.0.19.0.tar.gz	1d344aca4a9d2cb6be1d6e6a324e29a9803456cdc964c48963b2f1b53bb251ed
semeru-jre-openj9-11.0.19+7_openj9-0.38.0	ibm-semeru-open-jre_x64_linux_11.0.19_7_openj9-0.38.0.tar.gz	https://github.com/ibmruntimes/semeru11-binaries/releases/download/jdk-11.0.19+7_openj9-0.38.0/ibm-semeru-open-jre_x64_linux_11.0.19_7_openj9-0.38.0.tar.gz	35c25a4fe4cb1ab1c5e6605bc8dc6db54beca6f3d7745da2742bd0e627682ee3

joschi avatar Jun 04 '25 11:06 joschi

Looks like you have a PR that fixes this, anything else that'd be needed?

MPV avatar Jun 27 '25 09:06 MPV