asdf-java icon indicating copy to clipboard operation
asdf-java copied to clipboard

Support multiple release types and EA builds

Open jonatan-ivanov opened this issue 3 years ago • 2 comments

Fixes #176 The feature relies on the java_release_type property in .asdf which is not documented at the moment in this PR but I'm going to add a few lines of docs once I get some feedback.

jonatan-ivanov avatar Apr 20 '22 23:04 jonatan-ivanov

@joschi What do you think, should we merge this or are there other changes you want me to introduce?

jonatan-ivanov avatar May 21 '22 19:05 jonatan-ivanov

@halcyon What do you think? ^

jonatan-ivanov avatar May 22 '22 20:05 jonatan-ivanov

Hi @halcyon, Happy New Year, do you have any thoughts on this PR?

jonatan-ivanov avatar Jan 05 '23 19:01 jonatan-ivanov

@jonatan-ivanov Happy New Year! Sorry for the late response, LGTM!

halcyon avatar Jan 06 '23 15:01 halcyon

Thanks @jonatan-ivanov, sorry for looking at this so late.

bric3 avatar Mar 22 '23 15:03 bric3

@bric3 No problem. @halcyon Could you please take a look at this PR: https://github.com/halcyon/asdf-java/pull/198 it should fix an issue I made when I fixed issues raised in the comments on this PR.

jonatan-ivanov avatar Mar 22 '23 17:03 jonatan-ivanov

It would be nice to have some documentation for how to use this. This is what i eventually did, and it seemed to work:

echo java_release_type=ea >>~/.asdfrc
rm /tmp/asdf-java.cache/releases-*.tsv
asdf list all java

tomwhoiscontrary avatar Jul 03 '23 00:07 tomwhoiscontrary

@tomwhoiscontrary I wanted to add docs in another PR after this was merged in but I forgot about it, here's a PR: https://github.com/halcyon/asdf-java/pull/206

What you did seems ok, I usually remove the whole cache dir, please check the PR and let us know what you think.

jonatan-ivanov avatar Jul 03 '23 19:07 jonatan-ivanov