asdf-java icon indicating copy to clipboard operation
asdf-java copied to clipboard
verified publisher icon halcyon

System Java now works on macOS

Open delgurth opened this issue 4 years ago • 6 comments

Fixes https://github.com/halcyon/asdf-java/issues/132

Added special case for macOS in all 4 set-java-home scripts. Also created tests to validate this.

Updated the README.md to contain information on how to use the set-java-home scripts.

Cloned mstksg/get-package and released delgurth/get-package@v3 because it was using linuxbrew on Ubuntu and because I needed the apt-update (not released by mstksg) and -y flag in the apt-get install (when running github action on https://github.com/nektos/act). I've created an issue in the mstksg repository about this.

added .editorconfig because of mixed indent styles added .gitignore to ignore Intellij directory

asdf/asdf.sh needs $PWD in front as soon as you change directories

added tests for JAVA_HOME setting added tests for macOS JAVA_HOME setting in case version is set to system

Unfortunately the tests are not exactly as it would be on a system because of the way github actions spawn shells. Have to call the bash function _asdf_java_prompt_command and the fish & zsh function asdf_update_java_home to actually update the JAVA_HOME.

delgurth avatar Apr 05 '21 01:04 delgurth

LGTM.

@joschi thoughts?

halcyon avatar Apr 06 '21 21:04 halcyon

@joschi did you have time to look at this pull-request?

delgurth avatar Apr 10 '21 20:04 delgurth

Why this PR is still open since 2021-04-05?

akkadaya avatar Jan 19 '23 09:01 akkadaya

It's still open because the issues joschi commented on were not resolved.

halcyon avatar Jan 19 '23 15:01 halcyon

I'll try to redo the work, since it's giving quite some conflicts now.

delgurth avatar Jan 21 '23 11:01 delgurth

@delgurth if You need help, please let me know, I would be glad to help out

mrmeszaros avatar Aug 22 '23 15:08 mrmeszaros