Mastodon.py icon indicating copy to clipboard operation
Mastodon.py copied to clipboard

content_type is not ignored on incompatible servers

Open crablab opened this issue 1 year ago • 2 comments

From the documentation:

    **Specific to "pleroma" feature set:**: Specify `content_type` to set
    the content type of your post on Pleroma. It accepts 'text/plain' (default),
    'text/markdown', 'text/html' and 'text/bbcode'. This parameter is not
    supported on Mastodon servers, but will be safely ignored if set.

However, in the actual logic this is enforced very strictly:

https://github.com/halcy/Mastodon.py/blob/47aa316c36307ec891e41d34c1d4db91cca7b433/mastodon/statuses.py#L118

Expected behaviour: when setting this flag on an incompatible instance (eg. Mastodon) it's either sent to the server (which is safe?) or silently dropped. That way, clients of the library are abstracted from the underlying Mastodon server type.

Actual behaviour: exception is raised.

I'm happy to correct either the code or the docs. It's not clear to me which is the intended behaviour.

Apologies if I've got the wrong end of the stick.

crablab avatar Feb 14 '24 20:02 crablab

yeah I think the docs should be the behaviour we have (or, ideally: configurable at module level)

"not Mainline Mastodon" support is kind of a mess and needs to be reworked, probably, but if you want to go for a fix, I'd ask you to just take the check out

halcy avatar Feb 16 '24 17:02 halcy

I'll aim to get a PR in today to remove the check :)

crablab avatar Feb 19 '24 15:02 crablab