Ciprian Hacman

Results 492 comments of Ciprian Hacman

@avdhoot Could you share the rest of the error? There should be something regarding what exactly failed. Thanks!

/remove-lifecycle stale

/remove-lifecycle stale

This should probably be very similar to https://github.com/kubernetes/kops/pull/16006.

@karanrn Sure, it is conditional, same condition as for adding the port to the NLB.

@jim-barber-he Thank you for the explanation! Any way to test the https://github.com/kubernetes/kops/pull/16405 cherry-pick we did yesterday for kOps 1.28?

Ah, cool. Not sure if so easy to test the master brach build (there may be some nodeup changes), but please give it a try. We will also release an...

Perfect. Thank you for confirming @jim-barber-he! /close

@justinsb I see `ko` has `KO_DATA_PATH` so maybe split this into `KO_APP_PATH` and `KO_APP_NAME`? (just a thought to make things more consistent)