reveal.js icon indicating copy to clipboard operation
reveal.js copied to clipboard

Plugins errors after gulp build process

Open kovart opened this issue 3 years ago • 4 comments

I'm getting plugins errors that fail running my presentation.

notes.js:1 Uncaught TypeError: R is not a function
    at notes.js:1
    at notes.js:1
    at notes.js:1
(anonymous) @ notes.js:1
(anonymous) @ notes.js:1
(anonymous) @ notes.js:1
markdown.js:1 Uncaught TypeError: I is not a function
    at markdown.js:1
    at markdown.js:1
    at markdown.js:1
(anonymous) @ markdown.js:1
(anonymous) @ markdown.js:1
(anonymous) @ markdown.js:1
highlight.js:1 Uncaught TypeError: qs is not a function
    at highlight.js:1
    at highlight.js:1
    at highlight.js:1
(anonymous) @ highlight.js:1
(anonymous) @ highlight.js:1
(anonymous) @ highlight.js:1
(index):36 Uncaught ReferenceError: RevealMarkdown is not defined
    at (index):36

Reveal.js 7.1.2 System: Windows 10 + node v14.15.4 + npm 7.20.0

Steps to repdroduce: Download 7.1.2 zip archive (or master) npm i, npm run build, npm run start Open localhost:8000 and see the errors in a browser console.

Replacing the plugins from the archive resolves the issue.

kovart avatar Jul 17 '21 07:07 kovart

I have same issue on 4.1.2 version.

  • Reveal.js:4.1.2
  • System: OS: WIndows 10 10.0.18362
  • Binaries: Node: 14.15.4 npm: 6.14.13
  • Browser: Firefox 90.0(64bit)

souchi avatar Jul 27 '21 02:07 souchi

Having the same problem

  • Reveal 4.1.3
  • Windows 10
  • Node v14.17.3
  • npm 7.14.0

Note that 4.1.3 is shipped with a dist that is still 4.1.1 (according to the internal code). If I dont rebuilt the app but just run the server after npm install, it works

vanch3d avatar Aug 25 '21 11:08 vanch3d

Also having this issue. After running the build, I always have to revert my changes to the plugin directory, then it works fine.

joeskeen avatar May 16 '22 16:05 joeskeen

We have the same issue. Any updates on this topic?

Reveal 4.3.1 Windows 10, Debian Node v16.16.0 npm v8.11.0

ManticSic avatar Jul 25 '22 06:07 ManticSic

I changed the browserlist settings and it worked.

"browserslist": "> 2%, not dead",

souchi avatar Aug 07 '22 01:08 souchi

Thanks @souchi. No point in supporting IE11 anymore so I've update the browserlist in master. Has the added benefit of reducing the build times by 50%.

Can someone else who has encountered this issue test with the new browserlist to confirm that it works?

hakimel avatar Aug 08 '22 06:08 hakimel

Can someone else who has encountered this issue test with the new browserlist to confirm that it works?

I can confirm this. I've reproduced the issue on 039972c and it's fixed on b23d15c 🚀

darekkay avatar Aug 23 '22 13:08 darekkay

Thanks @darekkay!

hakimel avatar Aug 23 '22 13:08 hakimel