MassAutocomplete icon indicating copy to clipboard operation
MassAutocomplete copied to clipboard

Update massautocomplete.js

Open MartyIX opened this issue 9 years ago • 5 comments

This makes CSS styling of input box a bit easier.

I'm not sure if it isn't too specific use-case. But it would help me a lot. :)

MartyIX avatar Oct 15 '15 07:10 MartyIX

Can you give an example of when you would want to style a closed ac-container (rather then having it hidden)?

hakib avatar Oct 15 '15 07:10 hakib

I'm not styling ac-container. I'm styling the search <input> based on container state:

image

image

Note the corners of the <input>.

MartyIX avatar Oct 15 '15 07:10 MartyIX

My main concern is that if we descide to implement it this way it wont work as exepcted right out of the box if you descide not to use the theme.css - You would have to manually add the display:none rule to your own css.

How about a solution a long the lines of this example.

hakib avatar Oct 15 '15 17:10 hakib

Well, my implementation provides extra possibilities to style input but I wouldn't force the look to all users. If anybody would want the same look as above, then he/she can do that. That's really it. I mean if your concern is not performance, then it's a not a breaking change.

Your implementation does not behave as good as mine. I can see the input without rounded corners sometime when there should be rounded corners.

MartyIX avatar Oct 15 '15 17:10 MartyIX

Is there a chance that you merge this? As I stated before this is not a BC break, I just added a new class so a user has more possibilities and not less.

MartyIX avatar Nov 02 '15 08:11 MartyIX