Hajk icon indicating copy to clipboard operation
Hajk copied to clipboard

InfoClick: Resize breaks scroll

Open jesade-vbg opened this issue 2 years ago • 6 comments

If you resize the infoclick windows height, you wont be able to view all content in the window. Somewhere in the code it sets the window content height to a fixed px value, which in return does not get updated when the window resizes.

The right window shows the broken scroll window. image

jesade-vbg avatar Nov 01 '23 10:11 jesade-vbg

If I recall correctly, this does affect all components based on Window.js. It's more difficult to discover in plugins' windows, as they'r content's height usually doesn't change, but I remember I noticed it somewhere. Test and see. 😄

Anyway, yes, that's a valid bug.

jacobwod avatar Nov 01 '23 11:11 jacobwod

BTW, I'm looking into a similar issue and found that display: "contents" seems to be what breaks scrolling (in my case, I'm not sure it's the same as yours). Try reverting the change introduced in this commit (d979135c3b7c6e23da526e3256036e4759daf63f) and see if it helps.

jacobwod avatar Nov 03 '23 08:11 jacobwod

I might have a tiny quick-fix/patch to get this working for now. Will create branch.

jesade-vbg avatar Feb 02 '24 12:02 jesade-vbg

Branch https://github.com/hajkmap/Hajk/compare/develop...fix/1428-InfoClick-Resize-breaks-scroll

Line https://github.com/hajkmap/Hajk/commit/34cd38a60944060790a852342ca60e9dac9a8d71

jesade-vbg avatar Feb 02 '24 13:02 jesade-vbg

Hey @jesade-vbg, feel free to PR & merge when ready!

jacobwod avatar Feb 09 '24 11:02 jacobwod

Oh! I've forgotten about this one :) Will do PR & Merge.

jesade-vbg avatar Feb 09 '24 11:02 jesade-vbg