haiyanmeng

Results 57 comments of haiyanmeng

> 2. Disable implicit namespace resolution Today, all the namespaced objects sent from Config Sync to cli-utils have the `metadata.namespace` field explicitly set. Is it reasonable to expect this from...

> cli-utils already requires this. I don't think this is true. I tested with `kapply` built from the master, which doesn't require the `metadata.namespace` field of a Deployment object to...

Accurately speaking, `Applier.Run` requires the `metadata.namespace` field of a namespaced object to be explicitly set. kapply does not require this, since it [sets](https://github.com/kubernetes-sigs/cli-utils/blob/45a0b5b7e6b292c0a59c899aa50a3662a0c1cf7d/pkg/manifestreader/path.go#L48) the `metadata.namespace` field of a namespaced object...

> Perhaps we can create another PR with no changes as a baseline comparison? We can compare the performance based on the presubmit job history: https://oss.gprow.dev/job-history/gs/oss-prow-build-kpt-config-sync/pr-logs/directory/kpt-config-sync-presubmit-e2e-multi-repo

Setting the `parallel` flag to 21 causes lots of tests to fail. Here are the errors: ``` new.go:416: ERROR: waiting for ConfigSync Deployments to become available: 2 error(s) [1] KNV9999:...