haiwen
Video thumbnail feature broken
New moviepy versions can not be used for video thumbnails. The latest working version is 0.2.3.4. 0.2.3.5 will produce a lot of error entries in seahub.log.
2019-03-07 23:26:30,627 [ERROR] django.request:256 handle_uncaught_exception Internal Server Error: /thumbnail/c6072f86-aa46-4$Traceback (most recent call last):
I modified /seahub/seahub/thumbnails/utils.py (seafile 6.3.4) and removed the whole moviepy dependency. moviepy seems to be full of bugs. I just replaced a few lines of code to call ffmpeg directly as subprocess. The video thumbnail feature works like a charm now!
Please add something similar to your official release.
The following default value should be set to 1 because sometimes videos are shorter than 5s (seahub tries to recreate the thumbnail every time you reload the page, but always get an error):
# Use the frame at 5 second as thumbnail
THUMBNAIL_VIDEO_FRAME_TIME = 5
The user can set it to 5 or any other value if needed. Or just extract the very first frame from the video as default. This should work for all types of videos.
@mumpitzstuff can you submit a pr for this? I don't understand the dependency on moviepy.
