seafile-server icon indicating copy to clipboard operation
seafile-server copied to clipboard
verified publisher icon haiwen

add missing libs to configure.ac and Makefile.am

Open flokli opened this issue 8 years ago • 3 comments

Adding more PKG_CHECK_MODULES to configure.ac will cause configure phase to already fail if dependencies are not met. Additionally, it's good practice to use @FOO_LIBS@ instead of passing -lFOO directly.

This includes and goes a bit further than #12, as it requires EVHTP version 1.2.13, containing a keepalive fix.

/cc @niol, @ciil

flokli avatar Nov 19 '17 22:11 flokli

updated to also include oniguruma (as this does not come with libevhtp anymore).

flokli avatar Nov 21 '17 14:11 flokli

@niol Is there something missing to get this merged?

flokli avatar Dec 20 '17 00:12 flokli

I cannot test at the moment, but I think there may be missing the overlinking of onig that I describe in my comment: https://github.com/haiwen/seafile-server/pull/12#discussion_r137513336

niol avatar Dec 20 '17 10:12 niol