Peter Hunt
Peter Hunt
looks good! one question: would there be multiple builder objects per cri-o server or just one?
@littlejawa is this something you're helping with or are you looking for reinforcements?
what happens when you create the container with a different oci runtime?
> Is it because the layers were already mounted with the wrong flag, and not updated as part of the reload/restart? If so, is there anything else we could have...
/approve LGTM, thanks for investigating here! @cri-o/cri-o-maintainers (specifically @kwilczynski as you've poked this code lately) PTAL
@kwilczynski had a chance to look yet?
/ok-to-test
another option which I find myself leaning towards is just adding the GC call here: https://github.com/cri-o/cri-o/blob/main/internal/config/cnimgr/cnimgr.go#L50 before we notify the watching routines their plugin is ready, we call the GC....
hm good point. What if you added a call to cnimgr that took a list of stale pods that `server/server.go` produces, and calls GC on them? Such a function could...