Peter Hunt

icon company Red Hat

Results 635 comments of Peter Hunt

Container with exec entrypoint never restarted if conmon process exits

so the problem is that the container's lifecycle gets detached from cri-o. exec probes should still run for a spell--until the container exits. once it does, the node may get...

test: config tests should ignore default runtime environment variable

any reason not to do this in `setup()` instead?

test: config tests should ignore default runtime environment variable

/approve /ok-to-test makes sense LGTM

test: config tests should ignore default runtime environment variable

you've got a shfmt error @littlejawa

test: config tests should ignore default runtime environment variable

/retest /lgtm

test: config tests should ignore default runtime environment variable

/retest

ReopenContainerLog hangs for containers in a stopping state

hm I would not expect Kubelet to be specifying the Verbose flag, so it shouldn't be reaching that container.State() call. Do you have a pod that has a reproducer so...

ReopenContainerLog hangs for containers in a stopping state

@dlmather a little late, but I think this was fixed in https://github.com/cri-o/cri-o/pull/6925, would you be able to test it out and see?

ReopenContainerLog hangs for containers in a stopping state

sounds to me that this can be closed, do you agree @audrey-mux

cri-o api equivalent for crictl inspect command

you could do something similar as our internal client library https://github.com/cri-o/cri-o/blob/main/internal/client/client.go Alternatively, we could export this library--it has been fairly stable and I don't expect any of the items to...